Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname setting and "Delete all favorites" button #1473

Merged
merged 5 commits into from
Dec 7, 2024

Conversation

Sjmarf
Copy link
Member

@Sjmarf Sjmarf commented Dec 2, 2024

No description provided.

@Sjmarf Sjmarf requested a review from a team as a code owner December 2, 2024 10:43
@Sjmarf Sjmarf requested review from JakeShirley and mormaer and removed request for a team December 2, 2024 10:43
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

One minor wording suggestion

@Sjmarf Sjmarf enabled auto-merge (squash) December 7, 2024 14:31
@Sjmarf Sjmarf merged commit 194e355 into dev Dec 7, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/nickname-settings branch December 7, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants